Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add any missing properties in the message folder translation files #913

Open
3 tasks
eleanorreem opened this issue May 17, 2024 · 8 comments
Open
3 tasks
Assignees
Labels
bug fix Fix a bug complexity: beginner Time needed to do this ticket is less than 1 day. first-timers-friendly Appropriate for first time contributors. maintenance Maintenance / chore work state: approved Ready to go. Not blocked or pending.

Comments

@eleanorreem
Copy link
Contributor

eleanorreem commented May 17, 2024

Overview

We recently had a script contributed in issue #890 . This script checks whether there are any missing translations. We have all our translations in the /messages folder. Each folder has a .json file for each language.

Action Items

  • Fix the spelling in the filename the script. The script should be checkTranslation.js rather than checkTranlation.js. You will also need to update the package.json script. Use this script and see what missing translations are there. It should tell which files to look at and which translations to create.
  • Add missing properties to the files and add the translations (use google translate for now)
  • Run Cypress tests to ensure nothing is broken

Resources/Instructions

@eleanorreem eleanorreem added bug fix Fix a bug complexity: beginner Time needed to do this ticket is less than 1 day. maintenance Maintenance / chore work state: approved Ready to go. Not blocked or pending. first-timers-friendly Appropriate for first time contributors. labels May 17, 2024
@jwicksnin
Copy link

@eleanorreem Please assign this issue to me. Thanks!

Copy link
Contributor

Thank you for your interest in contributing to Chayn! Please carefully read the CONTRIBUTING.md file and the README.md file for guidance. Let us know if you have any questions. Good luck!

@eleanorreem
Copy link
Contributor Author

Assigned! Thanks for your interest. Let me know if you have any questions!

@jwicksnin
Copy link

Thanks! Wanted to give an update. I started on setting up the bloom backend locally but ran into an issue with Docker sadly. I spent some time debugging, and finally opened an issue with Docker. I'm going to try a few more things and hopefully Docker will get back to me.

@jwicksnin
Copy link

I found a workaround for the Docker issue and am now moving ahead. I documented the workaround in the Docker issue in case anyone else comes across it.

@jwicksnin
Copy link

Hi @eleanorreem I'm running into some yarn/formatting issues. If I run yarn format without having made any code changes, it updates about twenty files with extra commas, etc. Wondering if there is a quick fix in my vscode settings that I've overlooked? I have prettier set as the default formatter and am using the recommended extensions, etc. Thanks

@kyleecodes
Copy link
Member

kyleecodes commented Jun 6, 2024

Hey @jwicksnin thanks for letting us know, so sorry about this! We have implemented this pre-commit rule recently but forgot to format the project for a clean base to start with. I am fixing this right now.

For now, you can still push your changes like this:

  1. Add only the specific files you're changing to staging using git add <file name>

  2. When you commit, yarn format will still run but these changes wont be added to the commit that is pushed. You can verify with git status.

  3. You can remove those changes from yarn format locally using git stash. Then update your branch when the fix is ready.

@kyleecodes
Copy link
Member

Actually @jwicksnin this problem has just been fixed! You can simply update your branch now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug fix Fix a bug complexity: beginner Time needed to do this ticket is less than 1 day. first-timers-friendly Appropriate for first time contributors. maintenance Maintenance / chore work state: approved Ready to go. Not blocked or pending.
Projects
None yet
Development

No branches or pull requests

3 participants